From eb4fb29e3ba90662680df6ffc3e2412f24962aa5 Mon Sep 17 00:00:00 2001 From: Junyi Date: Fri, 2 Dec 2022 02:15:53 -0800 Subject: [PATCH] fix(plugin-workflow): fix transaction in trigger (#1186) --- packages/plugins/workflow/src/server/Plugin.ts | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/plugins/workflow/src/server/Plugin.ts b/packages/plugins/workflow/src/server/Plugin.ts index c9f867047..a964d9369 100644 --- a/packages/plugins/workflow/src/server/Plugin.ts +++ b/packages/plugins/workflow/src/server/Plugin.ts @@ -152,10 +152,7 @@ export default class WorkflowPlugin extends Plugin { } } - // @ts-ignore - const transaction = options.transaction && !options.transaction.finished - ? options.transaction - : await (workflow.constructor).database.sequelize.transaction(); + const transaction = await (workflow.constructor).database.sequelize.transaction(); const execution = await workflow.createExecution({ context, @@ -189,10 +186,7 @@ export default class WorkflowPlugin extends Plugin { execution.workflow = workflow; - // @ts-ignore - if (transaction && (!options.transaction || options.transaction.finished)) { - await transaction.commit(); - } + await transaction.commit(); setTimeout(() => this.dispatch(execution)); }