ruiling/tachybase_todo
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(plugin-cm): fix unique option default value to update (#768)

Browse Source
This commit is contained in:
Junyi 2022-08-23 08:59:36 +08:00 committed by GitHub
parent b6daa9ad69
commit e6a2dff79a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
packages/plugins/collection-manager/src/__tests__/field-options/indexes.test.ts
View File

@ -23,6 +23,36 @@ describe('field indexes', () => {
await app.destroy();
});
it('create unique constraint after added dulplicated records', async () => {
const tableName = 'test1';
// create an field with unique constraint
const field = await agent
.resource('collections.fields', tableName)
.create({
values: {
name: 'title',
type: 'string'
},
});
// create a record
const response1 = await agent.resource(tableName).create({
values: { title: 't1' }
});
// create another same record
const response2 = await agent.resource(tableName).create({
values: { title: 't1' }
});
const response3 = await agent.resource('fields').update({
filterByTk: field.id,
values: {
unique: true
}
});
expect(response3.status).toBe(400);
});
it('field value cannot be duplicated with unique index', async () => {
const tableName = 'test1';
// create an field with unique constraint

10
packages/plugins/collection-manager/src/server.ts
View File

@ -77,9 +77,9 @@ export class CollectionManagerPlugin extends Plugin {
this.app.db.on('fields.afterUpdate', async (model: FieldModel, { context, transaction }) => {
if (context) {
const prev = model.previous('options')?.unique;
const next = model.get('options')?.unique;
if (lodash.isBoolean(prev) && lodash.isBoolean(next) && prev !== next) {
const { unique: prev } = model.previous('options');
const { unique: next } = model.get('options');
if (Boolean(prev) !== Boolean(next)) {
await model.migrate({ transaction });
}
}
@ -180,7 +180,9 @@ export class CollectionManagerPlugin extends Plugin {
const errorHandlerPlugin = <PluginErrorHandler>this.app.getPlugin('@nocobase/plugin-error-handler');
errorHandlerPlugin.errorHandler.register(
(err) => err instanceof UniqueConstraintError,
(err) => {
return err instanceof UniqueConstraintError;
},
(err, ctx) => {
return ctx.throw(400, ctx.t(`The value of ${Object.keys(err.fields)} field duplicated`));
},