From ca01bdc306c610297f503134732bb6b3ab26033a Mon Sep 17 00:00:00 2001 From: jack zhang <1098626505@qq.com> Date: Thu, 14 Mar 2024 10:35:19 +0800 Subject: [PATCH] fix: remove env in colletion delete button (#3682) --- .../CollectionDeletedPlaceholder.test.tsx | 36 ++----------------- .../CollectionDeletedPlaceholder.tsx | 2 +- 2 files changed, 3 insertions(+), 35 deletions(-) diff --git a/packages/core/client/src/data-source/__tests__/components/CollectionDeletedPlaceholder.test.tsx b/packages/core/client/src/data-source/__tests__/components/CollectionDeletedPlaceholder.test.tsx index eb304d888..d716197d0 100644 --- a/packages/core/client/src/data-source/__tests__/components/CollectionDeletedPlaceholder.test.tsx +++ b/packages/core/client/src/data-source/__tests__/components/CollectionDeletedPlaceholder.test.tsx @@ -31,47 +31,15 @@ describe('CollectionDeletedPlaceholder', () => { }); describe('name exist', () => { - test("designable: true & process.env.NODE_ENV === 'development', render `Result` component", () => { - const NODE_ENV = process.env.NODE_ENV; - process.env.NODE_ENV = 'development'; - + test('designable: true, render `Result` component', () => { renderApp('test', true); - process.env.NODE_ENV = NODE_ENV; - expect(document.body.innerHTML).toContain('ant-result'); }); - test("designable: false & process.env.NODE_ENV === 'development', render `Result` component", () => { - const NODE_ENV = process.env.NODE_ENV; - process.env.NODE_ENV = 'development'; - + test('designable: false, render nothing', () => { renderApp('test', false); - process.env.NODE_ENV = NODE_ENV; - - expect(document.body.innerHTML).toContain('ant-result'); - }); - - test("designable: true & process.env.NODE_ENV !== 'development', render `Result` component", () => { - const NODE_ENV = process.env.NODE_ENV; - process.env.NODE_ENV = 'production'; - - renderApp('test', true); - - process.env.NODE_ENV = NODE_ENV; - - expect(document.body.innerHTML).toContain('ant-result'); - }); - - test("designable: false & process.env.NODE_ENV !== 'development', render nothing", () => { - const NODE_ENV = process.env.NODE_ENV; - process.env.NODE_ENV = 'production'; - - renderApp('test', false); - - process.env.NODE_ENV = NODE_ENV; - expect(screen.getByTestId('app').innerHTML.length).toBe(0); }); }); diff --git a/packages/core/client/src/data-source/components/CollectionDeletedPlaceholder.tsx b/packages/core/client/src/data-source/components/CollectionDeletedPlaceholder.tsx index e96e3244c..d92c582d4 100644 --- a/packages/core/client/src/data-source/components/CollectionDeletedPlaceholder.tsx +++ b/packages/core/client/src/data-source/components/CollectionDeletedPlaceholder.tsx @@ -61,7 +61,7 @@ export const CollectionDeletedPlaceholder: FC }).replaceAll('>', '>'); }, [message, nameValue, type, t, blockType]); - if (designable || process.env.NODE_ENV === 'development') { + if (designable) { if (type === 'Field') { return {messageValue}; }