From 9720c5262874cbfc163978173a86517830e73479 Mon Sep 17 00:00:00 2001 From: TomyJan Date: Mon, 12 Aug 2024 11:22:24 +0800 Subject: [PATCH] fix(telemetry): only shutdown telemetry in `stop` (#1454) Reviewed-on: https://git.daoyoucloud.com/daoyoucloud/tachybase/pulls/1454 Reviewed-by: sealday Co-authored-by: TomyJan Co-committed-by: TomyJan --- packages/core/server/src/application.ts | 8 -------- packages/core/telemetry/src/telemetry.ts | 5 +++++ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/core/server/src/application.ts b/packages/core/server/src/application.ts index 4beefdb1a..65575707d 100644 --- a/packages/core/server/src/application.ts +++ b/packages/core/server/src/application.ts @@ -458,10 +458,6 @@ export class Application exten await this.cacheManager.close(); } - if (this.telemetry.started) { - await this.telemetry.shutdown(); - } - const oldDb = this.db; this.init(); @@ -485,10 +481,6 @@ export class Application exten await this.cacheManager.close(); } - if (this.telemetry.started) { - await this.telemetry.shutdown(); - } - const oldDb = this.db; this.init(); diff --git a/packages/core/telemetry/src/telemetry.ts b/packages/core/telemetry/src/telemetry.ts index 74130e63e..c3d1f4eaf 100644 --- a/packages/core/telemetry/src/telemetry.ts +++ b/packages/core/telemetry/src/telemetry.ts @@ -81,6 +81,11 @@ export class Telemetry { this.started = true; } + /** + * 关闭链路追踪和指标监控, NOTE: 一旦调用此方法,将无法再次启动,需要重新实例化 + * @returns + * @memberof Telemetry + */ async shutdown() { await Promise.all([this.trace.shutdown(), this.metric.shutdown()]); this.started = false;