ruiling/tachybase_todo
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(plugin-workflow): fix interval number greater then 32-bits integer (#3592)

Browse Source
This commit is contained in:
Junyi 2024-03-01 17:49:45 +08:00 committed by GitHub
parent 2140df071d
commit 7c79e58df9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/plugins/@nocobase/plugin-workflow/src/server/triggers/ScheduleTrigger/StaticScheduleTrigger.ts
View File

@ -3,6 +3,8 @@ import parser from 'cron-parser';
import type Plugin from '../../Plugin'; import type Plugin from '../../Plugin';
import { SCHEDULE_MODE, parseDateWithoutMs } from './utils'; import { SCHEDULE_MODE, parseDateWithoutMs } from './utils';
const MAX_SAFE_INTERVAL = 2147483647;
export default class StaticScheduleTrigger { export default class StaticScheduleTrigger {
private timers: Map<string, NodeJS.Timeout | null> = new Map(); private timers: Map<string, NodeJS.Timeout | null> = new Map();
@ -80,8 +82,18 @@ export default class StaticScheduleTrigger {
if (toggle) { if (toggle) {
if (!this.timers.has(key)) { if (!this.timers.has(key)) {
const interval = Math.max(nextTime - Date.now(), 0); const interval = Math.max(nextTime - Date.now(), 0);
if (interval > MAX_SAFE_INTERVAL) {
this.timers.set(
key,
setTimeout(() => {
this.timers.delete(key);
this.schedule(workflow, nextTime);
}, MAX_SAFE_INTERVAL),
);
} else {
this.timers.set(key, setTimeout(this.trigger.bind(this, workflow, nextTime), interval)); this.timers.set(key, setTimeout(this.trigger.bind(this, workflow, nextTime), interval));
} }
}
} else { } else {
const timer = this.timers.get(key); const timer = this.timers.get(key);
clearTimeout(timer); clearTimeout(timer);